Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Player Network Test #75

Merged
merged 6 commits into from
May 4, 2024
Merged

Conversation

eshc123
Copy link
Owner

@eshc123 eshc123 commented May 4, 2024

Description

  • Player Nework Test 추가

Content

  1. RemotePlayerApiTest 추가
  2. FakePlayerNetworkDataSource 추가
  3. FakePlayerDataSourceTest 추가

Comment

테스트 실행 시 Success와 Error 명확하게 나누고 원하는 결과를 테스트하기 위해 FakePlayerNetworkDataSource 에서 setResponseForPlayerList 와 같은 set 함수를 두었습니다.

@eshc123 eshc123 requested a review from KanuKim97 May 4, 2024 08:41
@eshc123 eshc123 self-assigned this May 4, 2024
Copy link
Collaborator

@KanuKim97 KanuKim97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다! @eshc123 !
고생하셨어요! 👍

@KanuKim97 KanuKim97 merged commit 6e890d2 into dev May 4, 2024
1 check passed
@eshc123 eshc123 deleted the feature/add-player-network-test branch May 6, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants