-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Modified Match Detail Screen (1) #78
Conversation
…eature/mod-match-screen
@@ -0,0 +1,21 @@ | |||
package com.eshc.goonersapp.core.domain.model.match | |||
|
|||
enum class MatchDetailType { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eshc123 ! 질문이 있어요!
만약 OWNGOAL이 발생하게 되는 경우 기록은 상대팀에 표시되여야하는데 이 문제는 어떻게 처리해야할까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
홈팀 기준 어웨이팀 선수의 자책골이 있을 때 홈팀 Id 기준으로 필터링을 하면 자책골이 포함되어 있습니다.
teamId는 점수가 올라간 팀의 Id이고 선수 이름은 자책골을 넣은 선수로 나와서 PK와 마찬가지로 처리해주셔도 무방할 것 같습니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
넵! 확인했습니다! 감사합니다!
Description
Content
ENUM('GOAL', 'OWNGOAL', 'SUBSTITUTION', 'YELLOWCARD', 'REDCARD', 'YELLOWREDCARD', 'PENALTY', 'MISSED_PENALTY')
와 같습니다.이름을 동일하게 가져가는 것이 더 편하게 처리할 수 있을 것이라 생각되어 동일하게 가져갔습니다.
List<MatchDetail>.getScoreHistoryList()
를 추가하였습니다.MatchDetail
에scoringRecordText
를 추가하였습니다.Result screenshot
Comment