Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Modified Match Detail Screen (2) #82

Merged
merged 8 commits into from
May 22, 2024
Merged

[FEATURE] Modified Match Detail Screen (2) #82

merged 8 commits into from
May 22, 2024

Conversation

eshc123
Copy link
Owner

@eshc123 eshc123 commented May 20, 2024

Description

  • 수정된 디자인에 따른 MatchDetailScreen UI 하단 부분 수정

Content

  1. 라인업, 주목할만한 선수 UI 추가
  2. API 연동 후 데이터에 따라 수정이 있을 수도 있습니다.

Result screenshot

Comment

  1. 라인업 관련 API 연동 작업은 add-match-detail-api, 남은 UI 및 추가로 변경된 디자인 적용 작업은 mod-match-screen (3)에서 이어서 진행하도록 하겠습니다.

@eshc123 eshc123 requested a review from KanuKim97 May 20, 2024 13:39
@eshc123 eshc123 self-assigned this May 20, 2024
KanuKim97
KanuKim97 approved these changes May 22, 2024
View reviewed changes
Copy link
Collaborator

@KanuKim97 KanuKim97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eshc123 님 확인했습니다~!
👍

@eshc123 eshc123 merged commit f315350 into dev May 22, 2024
1 check passed
@eshc123 eshc123 deleted the feature/mod-match-screen-2 branch May 27, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KanuKim97 KanuKim97 KanuKim97 approved these changes

Assignees

@eshc123 eshc123

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eshc123 @KanuKim97