Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Modified Match Detail Screen (3) #85

Merged
merged 8 commits into from
Jun 1, 2024
Merged

[FEATURE] Modified Match Detail Screen (3) #85

merged 8 commits into from
Jun 1, 2024

Conversation

eshc123
Copy link
Owner

@eshc123 eshc123 commented May 31, 2024

Description

  • 수정된 디자인에 따른 MatchDetailScreen UI 하단 부분 수정(2)

Content

  1. 라인업, 주목할만한 선수 API 연동 및 UI 추가 수정
  2. 관련 Data Model 수정 (null 처리나 빠진 필드 추가)

Result screenshot

@eshc123 eshc123 added the feature New feature or request label May 31, 2024
@eshc123 eshc123 requested a review from KanuKim97 May 31, 2024 12:23
@eshc123 eshc123 self-assigned this May 31, 2024
KanuKim97
KanuKim97 approved these changes Jun 1, 2024
View reviewed changes
Copy link
Collaborator

@KanuKim97 KanuKim97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eshc123 님 확인했습니다!
고생하셨어요! 👍

@eshc123 eshc123 merged commit 7855d13 into dev Jun 1, 2024
1 check passed
@eshc123 eshc123 deleted the feature/mod-match-detail branch June 10, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KanuKim97 KanuKim97 KanuKim97 approved these changes

Assignees

@eshc123 eshc123

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eshc123 @KanuKim97