Throttle api #184
Open
Throttle api #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #184 +/- ##
==========================================
+ Coverage 74.78% 75.65% +0.86%
==========================================
Files 31 31
Lines 1170 1224 +54
==========================================
+ Hits 875 926 +51
- Misses 295 298 +3 ☔ View full report in Codecov by Sentry. |
NelsonVides
force-pushed
the
throttle_api
branch
4 times, most recently
from
176d6b9
to
5f883d9
Compare
DenysGonchar
reviewed
Jun 6, 2024
NelsonVides
force-pushed
the
throttle_api
branch
10 times, most recently
from
572f130
to
cbe472d
Compare
NelsonVides
force-pushed
the
throttle_api
branch
from
cbe472d
to
0bacea3
Compare
NelsonVides
force-pushed
the
throttle_api
branch
from
0bacea3
to
53cc8f8
Compare
NelsonVides
force-pushed
the
throttle_api
branch
3 times, most recently
from
6fdad6c
to
84bfb08
Compare
NelsonVides
force-pushed
the
throttle_api
branch
from
84bfb08
to
c16c3d6
Compare
DenysGonchar
reviewed
Aug 5, 2024
DenysGonchar
reviewed
Aug 5, 2024
src/throttle/amoc_throttle.erl
Outdated
| step_size => pos_integer(), | ||
| step_count => pos_integer(), | ||
| duration => pos_integer()} | | ||
| #{from_interarrival := interarrival(), |
There was a problem hiding this comment.
seems that from_interarrival cannot be 0 nor infinity in this case, the same is applicable to to_interarrival
DenysGonchar
reviewed
Aug 5, 2024
src/throttle/amoc_throttle.erl
Outdated
| interval => interval(), | ||
| parallelism => non_neg_integer()} | ||
| | #{interarrival := interarrival(), | ||
| parallelism => non_neg_integer()}. |
There was a problem hiding this comment.
what is the meaning of 0
DenysGonchar
reviewed
Aug 5, 2024
| %% @doc Sends and receives the given message `Msg'. | ||
| %% | ||
| %% Deprecated in favour of `wait/1' | ||
| -spec send_and_wait(name(), any()) -> ok | {error, any()}. |
There was a problem hiding this comment.
I think that this interface is actively used by amoc_arsenal_xmpp. if it's so, please add tickets for amoc_arsena/amoc_arsenal_xmpp
DenysGonchar
reviewed
Aug 5, 2024
src/throttle/amoc_throttle.erl
Outdated
| -spec change_rate(name(), rate(), interval()) -> ok | {error, any()}. | ||
| change_rate(Name, Rate, Interval) -> | ||
| -spec change_rate(name(), throttle()) -> ok | {error, any()}. | ||
| change_rate(Name, #{rate := Rate, interval := Interval}) -> |
There was a problem hiding this comment.
don't we want to support #{interarrival := interarrival()} format here?
DenysGonchar
reviewed
Aug 5, 2024
| Amoc throttle allows to: | ||
|
|
||
| - Setting the execution `Rate` per `Interval` | ||
| - Limiting the number of parallel executions when `Rate` is set to `infinity` |
There was a problem hiding this comment.
Rate is supposed to be the number of parrallel executions if Interval is 0
DenysGonchar
reviewed
Aug 5, 2024
guides/throttle.md
Outdated
|
|
||
| - Setting the execution `Rate` per `Interval` | ||
| - Limiting the number of parallel executions when `Rate` is set to `infinity` | ||
| - Setting the `Interarrival` time between actions. |
There was a problem hiding this comment.
this is not different to execution rate, but just another form of setting it.
NelsonVides
force-pushed
the
throttle_api
branch
from
3de218e
to
d1efeaa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making the API for throttle more friendly to use