-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interarrival as throttle #186
Draft
NelsonVides
wants to merge
8
commits into
throttle_api
Choose a base branch
from
interarrival_as_throttle
base: throttle_api
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Have the controller simply requesting the user supervisors to start all the users at once, and then have each user process await for throttle permission.
Unfortunately we cannot set the interarrival throttle to occur before the `proc_lib:init_ack/2` call because this would block the supervisor. This change also allows us to init processes completely asynchronously, as proc_lib is sync
NelsonVides
force-pushed
the
interarrival_as_throttle
branch
from
June 14, 2024 20:41
a5f279b
to
42d65c5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## throttle_api #186 +/- ##
================================================
+ Coverage 76.08% 77.03% +0.94%
================================================
Files 31 31
Lines 1221 1193 -28
================================================
- Hits 929 919 -10
+ Misses 292 274 -18 ☔ View full report in Codecov by Sentry. |
NelsonVides
force-pushed
the
throttle_api
branch
2 times, most recently
from
July 1, 2024 05:54
c16c3d6
to
2ae0719
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.