Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interarrival as throttle #186

Draft
wants to merge 8 commits into
base: throttle_api
Choose a base branch
from
Draft

Conversation

NelsonVides
Copy link
Collaborator

No description provided.

Have the controller simply requesting the user supervisors to start all
the users at once, and then have each user process await for throttle
permission.
Unfortunately we cannot set the interarrival throttle to occur before
the `proc_lib:init_ack/2` call because this would block the supervisor.

This change also allows us to init processes completely asynchronously,
as proc_lib is sync
@codecov-commenter
Copy link

codecov-commenter commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 89.65517% with 9 lines in your changes missing coverage. Please review.

Project coverage is 77.03%. Comparing base (84bfb08) to head (58f94c0).

Files Patch % Lines
src/amoc_controller.erl 77.77% 4 Missing ⚠️
src/users/amoc_users_sup.erl 88.88% 4 Missing ⚠️
src/users/amoc_users_worker_sup.erl 96.66% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           throttle_api     #186      +/-   ##
================================================
+ Coverage         76.08%   77.03%   +0.94%     
================================================
  Files                31       31              
  Lines              1221     1193      -28     
================================================
- Hits                929      919      -10     
+ Misses              292      274      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NelsonVides NelsonVides force-pushed the throttle_api branch 2 times, most recently from c16c3d6 to 2ae0719 Compare July 1, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants