-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CI scripts #5
Conversation
659ad0c
to
9a08f31
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5 +/- ##
===========================================
- Coverage 89.94% 71.42% -18.52%
===========================================
Files 2 1 -1
Lines 179 14 -165
Branches 13 0 -13
===========================================
- Hits 161 10 -151
+ Misses 18 4 -14 ☔ View full report in Codecov by Sentry. |
84f7100
to
8ff780f
Compare
07c58d7
to
d16da8c
Compare
ce9d4e9
to
e54b4c3
Compare
@big-r81 hi there! Related to #4, I've been trying here to modernise CI and now also adding windows to it, so that we can know its build won't be broken by any future changes. However, I cannot get windows to build in this runner, it keeps complaining that it can't find the <openssl/sha.h> header files. Do you know how does your windows build manage to find this header? Perhaps you can help me here :) |
rebar.config
Outdated
"$CFLAGS -std=c99 -O0 -g -Wall -Wextra -fPIC --coverage"}, | ||
{"(linux|solaris|freebsd|netbsd|openbsd|dragonfly|darwin|gnu)", | ||
"$LDLIBS -lcrypto --coverage"}, | ||
{"win32", "CFLAGS", "$CFLAGS ${OPENSSL_INSTALL_DIR}\include /O0 /DNDEBUG /Wall"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NelsonVides
this should work:
{"win32", "CFLAGS", "$CFLAGS /I${OPENSSL_INSTALL_DIR}/include /O2 /DNDEBUG /Wall"}
or with special escaping:
|
472ecbb
to
228d912
Compare
228d912
to
c1845e7
Compare
@NelsonVides Where do you set your env var |
@big-r81
I was expecting the env-vars to be set by any of the many gha plugins started here, or when installed by choco or vspkg, but none works. I haven't touched a windows machine in over 5 years so I honestly don't know much about how windows work here 🥲 |
@NelsonVides |
@NelsonVides In #6 there is a version which works for the Windows runner. You can use this as an idea. 😉 |
No description provided.