Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert docs to OTP27 style, with backwards compatibility #17

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

NelsonVides
Copy link
Collaborator

@NelsonVides NelsonVides commented Sep 17, 2024

The trick is extracted from beam-telemetry/telemetry#134

It also fixes some of the rendering, old docs weren't rendering well.

@NelsonVides NelsonVides force-pushed the otp27-docs branch 2 times, most recently from dff35ff to 6b411ed Compare September 17, 2024 07:13
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.28%. Comparing base (74cdf8e) to head (6b411ed).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #17      +/-   ##
==========================================
- Coverage   76.43%   75.28%   -1.15%     
==========================================
  Files           4        4              
  Lines         174      174              
==========================================
- Hits          133      131       -2     
- Misses         41       43       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@JanuszJakubiec JanuszJakubiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look great. I've added one comment regarding rebar.config with a small fix because the documentation is not building properly.

Copy link
Contributor

@JanuszJakubiec JanuszJakubiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏻

@JanuszJakubiec JanuszJakubiec merged commit 67e3de7 into main Sep 17, 2024
3 checks passed
@JanuszJakubiec JanuszJakubiec deleted the otp27-docs branch September 17, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants