Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Version support page #600
feat: Version support page #600
Changes from all commits
0d1965a
e0187e4
0ae3d7e
049f3dd
d445708
448aaf5
8bb76f0
2677190
72398a4
a298d40
a7cfdd3
4bea0e7
5452298
01e6468
485f016
e7da955
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I came across this approach as well. Using display: block for a
<table>
tag will change its display behaviour. When we set display: block, the<table>
element will behave like a block-level element instead of a table. I'm not sure if this is the best approach, so I'll check for any potential side effects.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setting
display: block
for the table works fine if the table occupies the full width on mobile. However, if the table doesn't occupy the full width, it causes the table's border to break.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I think we can fix that pretty easily using CSS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two small notes about the layout after this change, I'm not sure how important they are and whether they're intentional:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For 1, best I can tell, adding the "Version Support" link pushed everything up, but I have no idea why. Someone's who done web development more recently than I can probably figure it out pretty quickly. 😄
For 2, I've updated the styles.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
padding-block-end: 2rem; padding-bottom: 2rem;
This padding seems to force content to move upwards
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In 1, the ad and version shift slightly upward due to the
align-items: center
property applied to both the .hero>.content-container and .hero .grid elements. Thealign-items: center
property attempts to center-align the child elements, so adding a new element to the right column causes it to shift up slightly.To fix this, we can do the below steps:
step 1: align
.hero>.content-container
element normallystep 2: The left grid
span-1-7 content-container
element has some padding applied. Apply the same padding to the right grid as well.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!