Fix for Spack build action #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@theurich The test action is currently working in here - https://github.com/esmf-org/esmf/actions/runs/6695087117/job/18189863142 |
theurich
approved these changes
Oct 30, 2023
There was a problem hiding this comment.
It is a little strange that explicit apt-get install gfortran-12 gfortran-13 is needed, while there is a general apt-get install gfortran already present. But it is a small change, and obviously addresses the issue (i.e. runs cleanly now). Nice to have this figured out!
|
@theurich The test worked without any issue. Do you want me to merge this now? |
|
Yes, please merge into develop. I will then cherry-pick into release/8.6.0. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue with the automated Spack build. The actions tarted to fail due to missing gfortran (version 12 and 13) packages. This changes add extra code to install those packages explicitly.