Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/test coverage #337

Merged
merged 3 commits into from
Dec 17, 2024
Merged

Fix/test coverage #337

merged 3 commits into from
Dec 17, 2024

Conversation

theurich
Copy link
Member

Adding tests for two methods flagged by test coverage action:

  • ESMF_InfoLog()
  • ESMF_UtilStringDiffMatch()

@theurich theurich requested a review from oehmke December 16, 2024 23:32
oehmke
oehmke approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@oehmke oehmke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I guess I should have asked for a review on mine instead of just blithely pushing it in. :-)

@theurich theurich merged commit d9000f1 into develop Dec 17, 2024
5 of 6 checks passed
@theurich theurich deleted the fix/test-coverage branch December 17, 2024 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oehmke oehmke oehmke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theurich @oehmke