Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify NUOPC_CompAttributeIngest documentation #339

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Clarify NUOPC_CompAttributeIngest documentation #339

merged 1 commit into from
Dec 20, 2024

Conversation

danrosen25
Copy link
Member

@danrosen25 danrosen25 commented Dec 20, 2024 •
edited
Loading

@danrosen25
Clarify NUOPC_CompAttributeIngest documentation
63eb6a2 
* add note that whitespace delimited lists are not supported
@danrosen25 danrosen25 requested a review from theurich December 20, 2024 15:20
@danrosen25 danrosen25 self-assigned this Dec 20, 2024
@danrosen25
Copy link
Member Author

@theurich
I lost track of this after the ESMF performance testing demo. I tried to clean it up a little more. Is this better and ready to go?

@theurich theurich changed the base branch from develop to release/8.8.0 December 20, 2024 18:15
@theurich
Copy link
Member

Last beta tag on develop went on yesterday. I just changed the target of this PR to release/8.8.0 branch.

theurich
theurich approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@theurich theurich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve to go into release/8.8.0 branch.

@theurich theurich merged commit c9c3763 into esmf-org:release/8.8.0 Dec 20, 2024
4 checks passed
@theurich theurich mentioned this pull request Dec 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theurich theurich theurich approved these changes

Assignees

@danrosen25 danrosen25

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update documentation for NUOPC_CompAttributeIngest using freeformat with lists
2 participants
@danrosen25 @theurich