Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leak for parallel tests #1712

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Fix memory leak for parallel tests #1712

merged 2 commits into from
Oct 25, 2024

Conversation

MattCatz
Copy link
Contributor

@MattCatz MattCatz commented Jun 7, 2024

PLEASE NOTE the following text from the iperf3 license. Submitting a
pull request to the iperf3 repository constitutes "[making]
Enhancements available...publicly":

You are under no obligation whatsoever to provide any bug fixes, patches, or
upgrades to the features, functionality or performance of the source code
("Enhancements") to anyone; however, if you choose to make your Enhancements
available either publicly, or directly to Lawrence Berkeley National
Laboratory, without imposing a separate written license agreement for such
Enhancements, then you hereby grant the following license: a non-exclusive,
royalty-free perpetual license to install, use, modify, prepare derivative
works, incorporate into other computer software, distribute, and sublicense
such enhancements or derivative works thereof, in binary and source code form.

The complete iperf3 license is available in the LICENSE file in the
top directory of the iperf3 source tree.

  • Version of iperf3 (or development branch, such as master or
    3.1-STABLE) to which this pull request applies: master

  • Issues fixed (if any):
    congestion_used is set each iteration of the loop. For tests running parallel streams, the previous malloc-ed string (from strdup) is leaked.

  • Brief description of code changes (suitable for use as a commit message):
    If congestion_used is not NULL, free the existing string.

`congestion_used` is set each iteration of the loop. For tests running parallel streams, the previous malloc-ed string (from `strdup`) is leaked.
@bmah888
Copy link
Contributor

bmah888 commented Sep 25, 2024

Thanks for the PR! At first glimpse this looks like a good change to make (rather, two good changes to make).

@bmah888 bmah888 self-assigned this Sep 30, 2024
Copy link
Contributor

@bmah888 bmah888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good...merging after brief testing.

@bmah888 bmah888 merged commit 80e657f into esnet:master Oct 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants