[1/2] Remove Async/Blocking and Periodic/Target modes from systimer and timg #2542
+339
−1,197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MabezDev
commented
Nov 14, 2024
MabezDev
commented
Nov 14, 2024
MabezDev
commented
Nov 14, 2024
bugadani
reviewed
Nov 14, 2024
MabezDev
commented
Nov 14, 2024
MabezDev
commented
Nov 14, 2024
MabezDev
commented
Nov 14, 2024
bugadani
reviewed
Nov 14, 2024
bugadani
reviewed
Nov 14, 2024
Dominaezzz
reviewed
Nov 14, 2024
Dominaezzz
reviewed
Nov 14, 2024
|
I'm going to rework the systimer a bit in this PR, it's too annoying to get CI green without it. Converting back to draft for now. |
MabezDev
force-pushed
the
make-timers-dumb-again
branch
4 times, most recently
from
a331d31
to
bc06681
Compare
- Removes the notion of Unit being a resource, instead these are configured at the construction of `Systimer` (and can't be reconfigured after we move anything out of `Systimer`, this mimics the behaviour of `FrozenTimer` without having to deal with it
MabezDev
force-pushed
the
make-timers-dumb-again
branch
from
bc06681
to
390cb73
Compare
MabezDev
changed the title
|
skip change log for esp-wifi and esp-embassy-hal changes, they are breaking but not for anyone upgrading (esp-wifi etc are tightly coupled to esp-hal right now). |
6 tasks
jessebraham
reviewed
Nov 17, 2024
| } | ||
| } | ||
| /// Alarms created from the System Timer peripheral. | ||
| pub struct SysTimerAlarms { |
There was a problem hiding this comment.
Suggested change
| pub struct SysTimerAlarms { | |
| pub struct SystemTimerAlarms { |
We should probably be consistent with our naming.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
cargo xtask fmt-packagescommand to ensure that all changed code is formatted correctly.CHANGELOG.mdin the proper section.Extra:
Pull Request Details 📖
This PR removes much of the logic out of the lower level timers, and instead moves the logic to the
OneShotandPeriodictimer drivers.cc: #2321
I will do a follow up PR which adds the mode to the timer drivers, and implement
into_asyncand the eh traits there, as this PR got surprising large surprisingly quick.