Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPI: Implement missing traits #2823

Merged
merged 1 commit into from
Dec 19, 2024
Merged

SPI: Implement missing traits #2823

merged 1 commit into from
Dec 19, 2024

Conversation

bugadani
Copy link
Contributor

@bugadani bugadani commented Dec 17, 2024 •
edited
Loading

Closes #2791
Closes #2792

This also touches some other places because any_peripheral now derives more traits

@bugadani bugadani force-pushed the spi-derives branch 5 times, most recently from 91c459e to 48b93a3 Compare December 17, 2024 22:50
@bugadani bugadani marked this pull request as ready for review December 17, 2024 22:53
jessebraham
jessebraham approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

JurajSadel
JurajSadel approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@JurajSadel JurajSadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JurajSadel JurajSadel added this pull request to the merge queue Dec 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Dec 18, 2024
@bjoernQ bjoernQ enabled auto-merge December 18, 2024 08:13
@bugadani bugadani marked this pull request as draft December 18, 2024 08:14
auto-merge was automatically disabled December 18, 2024 08:14

Pull request was converted to draft

@bugadani bugadani force-pushed the spi-derives branch 3 times, most recently from e8dde2e to 3618119 Compare December 19, 2024 09:34
@bugadani bugadani marked this pull request as ready for review December 19, 2024 09:57
@bugadani bugadani added this pull request to the merge queue Dec 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Dec 19, 2024
@bugadani bugadani enabled auto-merge December 19, 2024 10:43
@bugadani bugadani added this pull request to the merge queue Dec 19, 2024
Merged via the queue into esp-rs:main with commit a3b3547 Dec 19, 2024
28 checks passed
@bugadani bugadani deleted the spi-derives branch December 19, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JurajSadel JurajSadel JurajSadel approved these changes

@jessebraham jessebraham jessebraham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SPI: Config doesn't derive Hash SPI: Driver structs don't derive PartialEq/Eq
3 participants
@bugadani @jessebraham @JurajSadel