Make more SPI interrupts available #2833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure this closes #2799, ESP32 and S2 aren't covered by this PR. |
bugadani
reviewed
Dec 18, 2024
Dominaezzz
reviewed
Dec 18, 2024
Dominaezzz
reviewed
Dec 18, 2024
bjoernQ
force-pushed
the
spi-interrupts
branch
from
cf000f2 to
6c6673b
Compare
bugadani
reviewed
Dec 19, 2024
esp-hal/CHANGELOG.md
Outdated
| @@ -35,6 +35,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| - ESP32-S2: DMA support for AES (#2699) | |||
| - Added `transfer_in_place_async` and embedded-hal-async implementation to `Spi` (#2691) | |||
| - `InterruptHandler` now implements `Hash` and `defmt::Format` (#2830) | |||
| - More interrupts are available in `esp_hal::spi::master::SpiInterrupt` | |||
bjoernQ
force-pushed
the
spi-interrupts
branch
from
6c6673b to
654a3e5
Compare
bugadani
reviewed
Dec 19, 2024
bjoernQ
force-pushed
the
spi-interrupts
branch
from
654a3e5 to
8213cee
Compare
MabezDev
requested changes
Dec 19, 2024
bjoernQ
force-pushed
the
spi-interrupts
branch
from
8213cee to
6e451d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
cargo xtask fmt-packagescommand to ensure that all changed code is formatted correctly.CHANGELOG.mdin the proper section.Extra:
Pull Request Details 📖
Description
Closes #2799
Testing
TransDoneis implicitly tested via async tests