Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert into c_char #2837

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Convert into c_char #2837

merged 1 commit into from
Dec 18, 2024

Conversation

bugadani
Copy link
Contributor

boo

@bugadani bugadani added the skip-changelog No changelog modification needed label Dec 18, 2024
bjoernQ
bjoernQ reviewed Dec 18, 2024
View reviewed changes
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SergioGasquez
SergioGasquez approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@SergioGasquez SergioGasquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bugadani bugadani enabled auto-merge December 18, 2024 18:34
@bugadani bugadani added this pull request to the merge queue Dec 18, 2024
Merged via the queue into esp-rs:main with commit f2b958b Dec 18, 2024
29 checks passed
@bugadani bugadani deleted the char branch December 18, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjoernQ bjoernQ bjoernQ left review comments

@Dominaezzz Dominaezzz Dominaezzz approved these changes

@SergioGasquez SergioGasquez SergioGasquez approved these changes

Assignees
No one assigned
Labels
skip-changelog No changelog modification needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bugadani @bjoernQ @SergioGasquez @Dominaezzz