Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AcknowledgeCheckFailedReason #2862

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bjoernQ
Copy link
Contributor

@bjoernQ bjoernQ commented Dec 23, 2024

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • I have used cargo xtask fmt-packages command to ensure that all changed code is formatted correctly.
  • My changes were added to the CHANGELOG.md in the proper section.
  • I have added necessary changes to user code to the Migration Guide.
  • My changes are in accordance to the esp-rs API guidelines

Extra:

Pull Request Details 📖

Description

This prepares for a maybe-future breaking change when we want to give the user an indication of an AckCheckFailed reason. For now it's just using Unknown but changing that shouldn't be a breaking change in future

Testing

CI

@bjoernQ bjoernQ force-pushed the prepare-i2c-ackcheckfailedreason branch from 620d33a to 420fdba Compare December 23, 2024 10:57
@bjoernQ
Copy link
Contributor Author

bjoernQ commented Dec 23, 2024

Prepares #2814

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant