Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I2c addr #2864

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+182 −74
Open

I2c addr #2864

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
642b675
I2C: prepare to support 10-bit addresses later
bjoernQ Dec 24, 2024
d9fc961
Introduce I2C Timeout enum
bjoernQ Dec 24, 2024
90d5dd4
Migration guide
bjoernQ Dec 24, 2024
bce4f17
CHANGELOG.md
bjoernQ Dec 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions esp-hal/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- I2C: Replaced potential panics with errors. (#2831)
- UART: Make `AtCmdConfig` and `ConfigError` non-exhaustive (#2851)
- UART: Make `AtCmdConfig` use builder-lite pattern (#2851)
- I2C: Have a dedicated enum to specify the timeout (#2864)

### Fixed

Expand Down
23 changes: 23 additions & 0 deletions esp-hal/MIGRATING-0.22.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,6 +318,29 @@ To avoid abbreviations and contractions (as per the esp-hal guidelines), some er
+ Error::ZeroLengthInvalid
```

## I2C Configuration changes

The timeout field in `Config` changed from `Option<u32>` to a dedicated `Timeout` enum.

```diff
- timeout: Some(10)
+ timeout: Timeout::BusCycles(10)
```

or (ESP32, ESP32-S2)

```diff
- timeout: None
+ timeout: Timeout::Max
```

or (other chips)

```diff
- timeout: None
+ timeout: Timeout::Disabled
```

## The crate prelude has been removed

The reexports that were previously part of the prelude are available through other paths:
Expand Down
Loading
Loading