Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Waveshare ESP32-S3-Tiny base on ESP32-S3FH4R2 chip (Closes #10633) #10634

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Godeffroy
Copy link

@Godeffroy Godeffroy commented Nov 21, 2024

Checklist

  1. Please provide specific title of the PR describing the change, including the component name (eg. „Update of Documentation link on Readme.md“)
  2. Please provide related links (eg. Issue which will be closed by this Pull Request)
  3. Please update relevant Documentation if applicable
  4. Please check Contributing guide
  5. Please confirm option to "Allow edits and access to secrets by maintainers" when opening a Pull Request

Description of Change

Add pin definition of the Waveshare board ESP32-S3-Tiny

Tests scenarios

I have tested my Pull Request on Arduino-esp32 core v2.0.17 based on ESP-IDF 4.4.7 with ESP32-S3-Tiny Board with this scenario
with PlatformIO on VsCode

Related links

Closes #10633
Adding Support in PlatformIO for Waveshare ESP32-S3-Tiny board

@CLAassistant
Copy link

CLAassistant commented Nov 21, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

github-actions bot commented Nov 21, 2024

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello Godeffroy, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against dab7469

Add support for Waveshare ESP32-S3-Tiny base on ESP32-S3FH4R2 chip
@Jason2866
Copy link
Collaborator

The changes are not complete. Adding in boards.txt are missing
An example https://github.com/espressif/arduino-esp32/pull/10549/files

@me-no-dev me-no-dev added the Status: Awaiting Response awaiting a response from the author label Nov 25, 2024
@me-no-dev
Copy link
Member

@Godeffroy will you add the necessary boards.txt values? We can not merge this as-is

@Godeffroy
Copy link
Author

I'll do it, I'm missing some values so I still didn't commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Awaiting Response awaiting a response from the author Type: 3rd party Boards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Waveshare ESP32-S3-Tiny base on ESP32-S3FH4R2 chip
4 participants