-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spi_slave_api.c: Allow to use GPIO 32 and 33 for interface signals. #248
base: master
Are you sure you want to change the base?
Conversation
There are some issues in the PR. can you please look into? |
As far as I see, the conflict is just a more literal one, not finally affecting the code's operation. It seems that some changes have been made to the master since I made the PR. I'll resolve it. |
Using consistently the IDF API instead of direct port access. There is a small performace drop compared to direct port access for setting the pin, but that can be accepted in favoer of consistence. GPIO33 for instance is used by Adafruit and NINA modules for the handshake signal, and these modules cannot be rewired. Signed-off-by: robert-hh <robert@hammelrath.com>
The PR is updated now. It has no conflict with the master branch and a test build works with Adafruit Airlft modules. |
I understand the rework pain. But this MR is important to handle GPIOs > 32.. |
Change looks good. We will pull this in next week. |
Thank you @robert-hh @JAndrassy for all your efforts and time .. |
@JAndrassy The actual PR does the same with the defines a few lines before defining the masks. I know that this is a kind of additional step. but GPIO_HS amd GPIO_DR are also used another place in the code.
|
@mantriyogesh Thanks. |
@robert-hh yes sorry. I have my changes in the 0.0.5 tag sources |
Using consistently the IDF API instead of direct port access. There is a small performace drop compared to direct port access for setting the pin, but that can be accepted in favoer of consistence.
GPIO33 for instance is used by Adafruit and NINA modules for the handshake signal, and these modules cannot be rewired.