Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Reduce verbosity of disabled component manager warning (IDFGH-13156) #14097

Closed
wants to merge 1 commit into from

Conversation

nebkat
Copy link
Contributor

@nebkat nebkat commented Jun 27, 2024

IDF_COMPONENT_MANAGER=0 is an advanced user option which doesn't have much of an effect unless there are components that have an idf_component.yml file, and in most cases dependencies can be resolved manually. Thus there should be no need for such a severe warning.

The warning message results in a warning symbol shown in IDE (CLion):
image

Copy link

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "build: Reduce verbosity of disabled component manager warning":
    • type/action should be one of [change, ci, docs, feat, fix, refactor, remove, revert, test]

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello nebkat, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against 227b846

@espressif-bot espressif-bot added the Status: Opened Issue is new label Jun 27, 2024
@github-actions github-actions bot changed the title build: Reduce verbosity of disabled component manager warning build: Reduce verbosity of disabled component manager warning (IDFGH-13156) Jun 27, 2024
@kumekay
Copy link
Collaborator

kumekay commented Sep 11, 2024

@nebkat Thank you for the PR, the change looks good to me

@hfudev WDYT?

@kumekay kumekay requested a review from hfudev September 11, 2024 15:50
@hfudev
Copy link
Member

hfudev commented Sep 26, 2024

LGTM!

@hfudev hfudev added the PR-Sync-Merge Pull request sync as merge commit label Sep 26, 2024
@hfudev
Copy link
Member

hfudev commented Sep 26, 2024

sha=227b84636c5eb8dae63f13f65507349e2e77fa87

@hfudev hfudev added PR-Sync-Merge Pull request sync as merge commit and removed PR-Sync-Merge Pull request sync as merge commit labels Sep 26, 2024
@espressif-bot espressif-bot added Status: Reviewing Issue is being reviewed Status: Done Issue is done internally Resolution: NA Issue resolution is unavailable and removed Status: Opened Issue is new Status: Reviewing Issue is being reviewed labels Sep 26, 2024
@hfudev
Copy link
Member

hfudev commented Oct 3, 2024

@nebkat Thank you for your contribution. The commit has been cherry-picked as 8c1ecc4 and merged internally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Sync-Merge Pull request sync as merge commit Resolution: NA Issue resolution is unavailable Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants