-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add files via upload (IDFGH-13958) #14789
Conversation
👋 Hello xsmilexxxl, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
Hey @xsmilexxxl We're glad to see this sensor driver been supported on the IDF platform. But we think the esp-idf repository is not the best place to host these sensor drivers. Alternatively, we highly recommend users to use the component registry. Yes, to maintain the idf component under your namespace and upload it to the component registry (the way like the npm in the node js ecosystem). The benefit is, you can release a new version of this driver at anytime, it doesn't have to be coupled with the esp-idf's release cycle. For how to use the component manager, I suggest you watching this video. The document of the component manger can be found here. |
#define BMXAPI extern | ||
|
||
/** | ||
* 用于驱动设置的匿名结构体。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest not using Chinese in the API comment.
Thanks for contribution again, please help check suggestions here #14789 (comment), feel free to reopen. |
bmx280 for esp-idf