Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update ata closed authority #1528

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

feat: update ata closed authority #1528

wants to merge 6 commits into from

Conversation

justinenerio
Copy link
Contributor

@justinenerio justinenerio commented Jul 23, 2024 •
edited
Loading

Changes

  • removes ata transfer fee for incoming links
  • replaces transfer with setAuthority to closedAccount
  • adds ataCreated to analytics
  • removes incoming fee label

Related issues

Fixes #1415

Checklist

  • PR is ready for review (if not, it should be a draft).
  • PR title follows Conventional Commits guidelines.
  • Screenshots/video added.
  • Tests added.
  • Self-review done.

@justinenerio justinenerio marked this pull request as ready for review July 24, 2024 07:24
@justinenerio justinenerio marked this pull request as draft August 12, 2024 04:23
@justinenerio
Copy link
Contributor Author

can be merged after https://github.com/espresso-cash/ec-backend/pull/78

@justinenerio justinenerio mentioned this pull request Aug 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ookami-kb ookami-kb Awaiting requested review from ookami-kb ookami-kb is a code owner

@Jaxiii Jaxiii Awaiting requested review from Jaxiii

@Merculiar Merculiar Awaiting requested review from Merculiar

At least 0 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pay for the ATA of our users by setting us as closeAuthority and track it on Mixpanel
1 participant
@justinenerio