facebook: use default empty string for primary keys instead of required

estuary · Mar 20, 2024 · 59cefb7 · 59cefb7
1 parent 0bba128
commit 59cefb7
Show file tree

Hide file tree

Showing 2 changed files with 84 additions and 58 deletions.
diff --git a/source-facebook-marketing/source_facebook_marketing/streams/base_insight_streams.py b/source-facebook-marketing/source_facebook_marketing/streams/base_insight_streams.py
@@ -301,16 +301,9 @@ def get_json_schema(self) -> Mapping[str, Any]:
             if k not in schema["properties"]:
                 continue
 
-            tys = schema["properties"][k]["type"]
-
-            if "null" in tys:
-                schema["properties"][k]["type"].remove("null")
-
-            if "required" not in schema:
-                schema["required"] = []
-
-            if k not in schema["required"]:
-                schema["required"].append(k)
+            typ = schema["properties"][k]["type"]
+            if "string" in typ or typ == "string":
+                schema["properties"][k]["default"] = ""
 
         return schema