Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update saas connectors to estuary-cdk #1326

Merged
merged 7 commits into from
Mar 11, 2024
Merged

update saas connectors to estuary-cdk #1326

merged 7 commits into from
Mar 11, 2024

Conversation

jgraettinger
Copy link
Member

@jgraettinger jgraettinger commented Mar 5, 2024

  • Update all forked airbyte connectors to use the estuary-cdk and it's airbyte shim.
  • Clean them up into a new, canonical layout for these connectors.
  • Get their tests passing -- which required fixes in some cases.

Workflow steps:

(How does one use this feature, and how has it changed)

Documentation links affected:

(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)

Notes for reviewers:

(anything that might help someone review this PR)


This change is Reviewable

@jgraettinger jgraettinger marked this pull request as ready for review March 5, 2024 23:38
@jgraettinger jgraettinger requested a review from jshearer March 6, 2024 17:21
@jgraettinger
Copy link
Member Author

@jshearer bump?

Copy link
Contributor

@jshearer jshearer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a look over the changes, looks good to me! AFAICT the source of the connectors themselves didn't change, and this was just moving them around/getting the original connector tests running/passing.

@jgraettinger jgraettinger merged commit 0f4c8c4 into main Mar 11, 2024
52 of 53 checks passed
@jgraettinger jgraettinger deleted the johnny/update-saas branch March 11, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants