Added new connector: source-google-analytics-data-api #1368
Conversation
Luishfs
requested review from
williamhbaker
and removed request for
jgraettinger
source-google-analytics-data-api/tests/snapshots/snapshots__discover__capture.stdout.json
Outdated
Show resolved
Hide resolved
source-google-analytics-data-api/tests/snapshots/snapshots__discover__capture.stdout.json
Outdated
Show resolved
Hide resolved
Luishfs
force-pushed
the
source-google-analytics
branch
from
3fa612a to
1a5b0cc
Compare
copying the image behaviour
Remote Repo URL: git@github.com:airbytehq/airbyte.git Source name: 019153f Source Commit ID: 019153f178d221bbf602c21efea54f78042544ca Source Repo Prefix: airbyte-integrations/connectors/source-google-analytics-data-api/ Import Path: source-google-analytics-data-api/ License Type: MIT License Path: airbyte-integrations/connectors/source-google-analytics-data-api/metadata.yaml git-merge-subpath: 019153f178d221bbf602c21efea54f78042544ca airbyte-integrations/connectors/source-google-analytics-data-api source-google-analytics-data-api
Luishfs
force-pushed
the
source-google-analytics
branch
from
1a5b0cc to
817eb8d
Compare
Removed unused files Added new test files & modified test.flow.yaml Fixed config.yaml
Luishfs
force-pushed
the
source-google-analytics
branch
from
817eb8d to
594a5b6
Compare
There was a problem hiding this comment.
See inline comments. Also we need to test the migration scenario, see here for more information on what this would entail.
source-google-analytics-data-api/tests/snapshots/snapshots__spec__capture.stdout.json
Show resolved
Hide resolved
| @@ -4,6 +4,17 @@ | |||
| "$schema": "https://json-schema.org/draft-07/schema#", | |||
There was a problem hiding this comment.
We should have capture snapshot output tests as well if at all possible.
There was a problem hiding this comment.
@williamhbaker Does this account posses a valid dashboard so i can do that?
There was a problem hiding this comment.
I'm not honestly sure what a dashboard is in the context of google analytics. I think you set up the test property, though? So if its possible to add some data to 431462875 and capture it + snapshot, that would be ideal. Otherwise it'll be tough to feel confident the new version works, if we haven't been able to test it.
There was a problem hiding this comment.
It is really hard as we need a real website with the hook inside the pages html.
We can try with other data sources, but cant put it inside the CI pipeline without a estuary version of it.
There was a problem hiding this comment.
@williamhbaker How do you want to proceed? Test locally and validate the data?
There was a problem hiding this comment.
My objective is to get confidence that the new connector outputs data in roughly the same way as the old connector. Since there aren't any major differences in the output schemas, that's one point of confidence.
I'm hearing that it is not practical to have automated CI output tests, and that's kind of a bummer but it is what it is.
It would certainly be nice to know that this new connector has some ability to capture data. If there's a way for you to test it locally and validate the data, that would be great, and you can just add a description of what you did here and we'll call it good based on that manual testing.
I'm imagining make a static HTML page and opening it in my browser locally that has the hook in it and using that to generate some data in google analytics. I don't know if that would actually work though. If it does, I'd wonder why we couldn't have that as a CI test, since I would think that once the data is in google analytics it would stay there for later test runs, but maybe that is a flawed assumption.
|
@williamhbaker As discussed earlier, im closing this PR and using this PR as the main one for this import, now with the correct branch set inside estuary/connectors |
Description:
(Describe the high level scope of new or changed features)
Workflow steps:
(How does one use this feature, and how has it changed)
Documentation links affected:
(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)
Notes for reviewers:
(anything that might help someone review this PR)
This change is