Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

facebook: use default empty string for primary keys instead of required #1386

Merged
merged 3 commits into from
Mar 20, 2024

Conversation

mdibaiee
Copy link
Member

@mdibaiee mdibaiee commented Mar 19, 2024

Description:

  • Use a default string so we can capture these collections even though sometimes the keys do not exist in certain documents. In these cases those documents will get reduced together (this is what has happened previously as well, since these fields were not even marked as a key)

Workflow steps:

(How does one use this feature, and how has it changed)

Documentation links affected:

(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)

Notes for reviewers:

(anything that might help someone review this PR)


This change is Reviewable

@mdibaiee mdibaiee requested a review from jonwihl March 19, 2024 15:39
@jgraettinger
Copy link
Member

jgraettinger commented Mar 19, 2024

This is potentially applied to format: date fields. Default values must pass all schema validations. If you tried to actually preview a collection with these schemas I believe they'd failed with a build error. The default would need to be aware of this and use a valid date or date-time sentinel (depending on format).

@mdibaiee mdibaiee merged commit d7d6473 into main Mar 20, 2024
50 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants