Add Source Dropbox #1499
Closed
Add Source Dropbox #1499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamhbaker
requested changes
Apr 25, 2024
|
In addition to the inline comments, please clean up the commit history prior to submitting this for review again. We'd like the merged set of commits to be useful for future readers of the code, rather than a chronology of all the changes made during the review process. |
Z33DD
commented
May 2, 2024
| ) | ||
|
|
||
| type config struct { | ||
| Path string `json:"path" yaml:"path"` |
There was a problem hiding this comment.
Those YAML tags are necessary for reading test credentials
|
Docs PR: estuary/flow#1458 |
Add OAuth2 authentication for Dropbox API Refactor OAuth2Spec function in oauth2.go and made the necessary changes to the connector schema. Refactor OAuth2Spec function and add Credentials struct for Dropbox API authentication Refactor Dropbox authentication schema and add new fields Refactor Dropbox authentication schema and add new fields Refactor Dropbox authentication schema and add new fields Refactor Dropbox authentication schema and add new fields Refactor authentication schema to remove the refresh_token field Refactor Dropbox authentication schema and remove unnecessary fields Refactor Dropbox authentication schema and remove unnecessary fields Fix mapping Update schema Update Dropbox authentication schema to add refresh_token Refactor Dropbox authentication to use OAuth2 client instead of access token Implement Token source for OAuth2 flow Simplify code Revert unnecessary changes Revert changes to Dockerfile Remove unnecessary comments Simplify code Remove debug logging Remove TestAzureBlobStore_getConfigSchema from source-dropbox/.snapshots
Minor refactor Fix recursive queries problem Implement proposed changes Fix pagination issues and update tests Remove pagination limit in Dropbox connector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This connector uses OAuth for Authentication, so we need to create an app on the Dropbox console like in the image bellow:
After setting the Estuary's branding, go to the permission tab and make sure that
account_info.read,files.metadata.readandfiles.content.readare selected.On the overview tab, copy the OAuth credentials and set the Redirect URIs.
Now, apply to production and wait.
Workflow steps:
(How does one use this feature, and how has it changed)
Documentation links affected:
Add docs for this connector: estuary/flow#1458
Notes for reviewers:
(anything that might help someone review this PR)
This change is