Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source-hubspot: changing properties endpoint to v3 #2079

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

source-hubspot: changing properties endpoint to v3 #2079

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0f25bf6
source-hubspot: changing properties endpoint to v3
Luishfs Oct 23, 2024
1ac1669
source-hubspot: fixing tests & snapshots
Luishfs Oct 25, 2024
cdfe3fb
source-hubspot: nit: updating snapshots
Luishfs Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions source-hubspot/config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,7 @@ credentials:
client_id_sops: ENC[AES256_GCM,data:cN4R7R7ixwd0QiX9uanxOSx9xsGmTi4oEHX6vNbTAdY6VFiU,iv:2fvIsHIOv4YtAgWb0P777akB5LZyRNXXpRU9IJp2q5Y=,tag:VqxBHJO6I21yMiHpw6nHBg==,type:str]
client_secret_sops: ENC[AES256_GCM,data:UlJR+XVn0rgji2eoxy6pe0xUFa3QqrfGyxsGDwo3ntRR4z0/,iv:zn0YVI1gE5vOKzfeaCw1qYe76375RhRBJdPDL/mO90k=,tag:P0ziOgenDQKUUdZyFp8sZA==,type:str]
credentials_title: OAuth Credentials
refresh_token_sops: ENC[AES256_GCM,data:XPQZka/ecPGbVEC2vW5p0c9ogQnTo1s/gM3+qED4o364fL/e,iv:fDoSfNULUVXY7G/w7pvkiiTHykZnsKfK99F3lUZxU08=,tag:48VDYM6CzYXvbhwPZNjOLw==,type:str]
access_token_sops: ""
refresh_token_sops: ENC[AES256_GCM,data:pv1aNqErp9iHsVpNk1uPExiwQfuAq2KFmAS9okXiBDAChIu4,iv:PWxe5ZwPd5GGOiW2MtEucGbrRbZs5U0zLYIvTsNBw5c=,tag:dblxNOWFmXynn1oqdslWBQ==,type:str]
token_expiry_date: "2024-02-01T17:01:21.703Z"
start_date: "2024-01-01T12:00:00Z"
sops:
Expand All @@ -15,8 +14,8 @@ sops:
azure_kv: []
hc_vault: []
age: []
lastmodified: "2024-02-15T21:12:36Z"
mac: ENC[AES256_GCM,data:4RO1xaK3t+d0okl0FGpcXbaxH/j0wuJ5IAXT+t8qreUd0qfTDTWIJdcI27/x7oO3k13q15Ri8SKJ/rSUOHPSPtbmjVPUqQyBLaM2BO0zqrEJcSINhNkW9ldqMYet/QhUVZ+fY56rv1p1amCw70+jvpHFjaoLaiwww3jaJeofb5I=,iv:J2YUq8ceQ+Edrl9KGtiXgHUTha5MoyA4L8GCAI5aHbE=,tag:OexGNsQXRZFmwddX6nAf3g==,type:str]
lastmodified: "2024-10-22T20:20:58Z"
mac: ENC[AES256_GCM,data:mkI3O3JhsW0gHvi5+B7A99ElpRplwY0FTmeOlQvhuQN7suz4zesixZvFdVTLwADE/nRxQQ96Dl/MUUYaANwa+PkJt7ggluC93y3YmEBNmbtHebqRpSox9TvlvE76QInKu18DQOfeOiYen7DOM+Eh8kwkAL+wRLiLbS2xVuldJIQ=,iv:KM7QuzRVScb9q9BpU7/c0TYWm7sgg1Ck4+WriD1qH+k=,tag:26ulOQDmEF7pyLmdRnaf7A==,type:str]
pgp: []
encrypted_suffix: _sops
version: 3.8.1
11 changes: 9 additions & 2 deletions source-hubspot/source_hubspot/streams.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -752,9 +752,16 @@ def properties(self) -> Mapping[str, Any]:
f"to be able to fetch all properties available."
)
return props
data, response = self._api.get(f"/properties/v2/{self.entity}/properties")
for row in data:
if self.__class__ is CustomObject:
data, response = self._api.get(f"/crm/v3/properties/p_{self.entity}")
else:
data, response = self._api.get(f"/crm/v3/properties/{self.entity}")

self.logger.debug(data)
if not data.get("results"):
return props

for row in data["results"]:
#TODO(johnny): This is kicking the can on a schema mistake that we should fix.
if self.name == "contacts" and row["name"] == "hs_latest_source_timestamp":
props[row["name"]] = {"type": ["null", "string"], "format": "date"}
Expand Down
Loading
Loading