source-klaviyo: filter Profiles with > instead of >=
#2115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My earlier commit (dfbe8b5) was too broad in changing all incremental streams to use `"greater-or-equal"` in the `filter` query param. The `/profiles` endpoint used by both the `Profiles` and `GlobalExclusions` streams do not support filtering with `"greater-or-equal"`, so they have to use `"greater-than"`.
Alex-Bair
added
the
change:unplanned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
My earlier commit (dfbe8b5 in PR #2037 ) was too broad in changing all incremental streams to use
>=in thefilterquery param. The/profilesendpoint used by both theProfilesandGlobalExclusionsstreams do not support filtering with>=, so they have to use>.For streams that do use
>, I subtracted one second (the smallest time granularity for Klaviyo timestamps) before the first request to avoid missing records that were updated in the same second but weren't available in the API at the exact same time.Workflow steps:
(How does one use this feature, and how has it changed)
Documentation links affected:
(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)
Notes for reviewers:
Although
/profilesdoes not support>=filtering & the API returns a400response when trying to filter with>=, existing tasks have failed silently. I'm not sure exactly why tasks didn't fail / an error message wasn't logged, but I made issue #2114 to track this.Tested on a local stack. Confirmed:
ProfilesandGlobalExclusionsstreams now work, are incremental, and no longer silently fail.This change is