source-klaviyo: raise errors for Profiles and GlobalExclusions
#2118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `raise_on_http_errors` property has been suppressing errors for the `Profiles` and `GlobalExclusions` streams. It looks like this was originally done because Klaviyo sometimes returns a `503` when paginating per Airbyte comments. I have not been able to replicate that. If that does happen, we should now get an error message, the shard should fail & restart, and the stream should pick up where it last left off paginating.
Alex-Bair
added
the
change:unplanned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The
raise_on_http_errorsproperty has been suppressing all errors for theProfilesandGlobalExclusionsstreams. It looks like this was originally done because Klaviyo sometimes returns a503when paginating per the Airbyte comments. I have not been able to replicate this. If that does happen, we should now get an error message, the shard should fail & restart, and the stream should pick up where it last left off paginating.Workflow steps:
(How does one use this feature, and how has it changed)
Documentation links affected:
(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)
Notes for reviewers:
Tested on a local stack. Confirmed that HTTP errors (specifically a
400response) forProfilesandGlobalExclusionsfails the shard and logs out an error message.This change is