network-tunnel: Don't fail on Stop() of nil tunnel #2175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently `source-oracle` does an unconditional `db.tunnel.Stop()` during shutdown regardless of whether a network tunnel exists, but the implementation of `Stop()` assumes that the tunnel must not be nil. This disagreement could be resolved in either direction, but it seemed cleaner to just make `Stop()` a no-op for nil receivers.
willdonnelly
added
the
change:unplanned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Currently
source-oracledoes an unconditionaldb.tunnel.Stop()during shutdown regardless of whether a network tunnel exists, but the implementation ofStop()assumes that the tunnel must not be nil. This disagreement could be resolved in either direction, but it seemed cleaner to just makeStop()a no-op for nil receivers.This change is