Get correct label from config #21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested it of course
|
|
nope this is not the way bcs when any other resource adds |
Arctos2win
requested changes
Nov 5, 2023
| @@ -217,10 +217,8 @@ function DeleteSpawnedVehicles() | |||
| end | |||
|
|
|||
| function getVehicleLabelFromHash(hash) | |||
| local model = string.lower(GetDisplayNameFromVehicleModel(hash)) | |||
There was a problem hiding this comment.
keep this otherwise all vehicles that aren't in the config don't have a name.
|
@Arctos2win Hi! Can you tested this? |
|
@Arctos2win Hi! Any status? |
|
I made another pull request and I fixed this problem, i closed this pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the issue of the vehicle label not getting correctly.
Since
GetDisplayNameFromVehicleModeluses the name from the vehicles.meta and some vehicles like the "seashark", "seashark2", "seashark3" share the same name: "seashark" it won't be able to return the correct vehicle name as listed in the config.Issue mentioning this: #20