Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/dat 357 etq u si mon organisation a deja des scopes hubee dila #180

Conversation

Isalafont
Copy link
Contributor

@Isalafont Isalafont commented May 6, 2024

  • Grisé les scopes si déjà sélectionné pour la même organisation
Capture d’écran 2024-05-06 à 16 16 02
  • Ne pas permettre à l'utilisateur de démarrer une demande de formulaire si tous les scopes ont déjà été soumis / validés et que les habilitations / demandes sont toujours valide.
  • Tester en local que tout fonctionne
  • Afficher une alert explicative sur l'URL /demandes/hubee-dila/nouveau -> A faire dans un autre ticket pour couvrir HubEE Dila et HubEE CertDC
  • Ajout de test cucumber

@Isalafont Isalafont force-pushed the feature/dat-357-etq-u-si-mon-organisation-a-deja-des-scopes-hubee-dila branch 2 times, most recently from 9cb7602 to d568a36 Compare May 6, 2024 14:24
@Isalafont Isalafont requested a review from mehdi-farsi May 7, 2024 16:19
Isalafont and others added 22 commits May 15, 2024 15:43
  - Authorization_definitions.yml
  - Authorization_request_forms.yml
  - Model AuthoriationRequest::HubEEDila
  - Method Helper search for current_organization previous selected scopes for validated, changes requested and submitted state
  - Add method in authorization_request_forms/shared/_scopes.html.erb view to disabled already selected scopes.
  - Need to test it to verif everything is working correctly
  - As hubee dila is a multiple steps form, policies in view has add to handle this case.
…thorization request with the same scope checked already exists
@mehdi-farsi mehdi-farsi force-pushed the feature/dat-357-etq-u-si-mon-organisation-a-deja-des-scopes-hubee-dila branch from 862b2e0 to 373485c Compare May 15, 2024 13:43
@mehdi-farsi mehdi-farsi requested a review from SchweisguthN May 15, 2024 13:44
Copy link
Contributor

@mehdi-farsi mehdi-farsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Isalafont Isalafont merged commit 8e5f64e into develop May 15, 2024
7 checks passed
@Isalafont Isalafont deleted the feature/dat-357-etq-u-si-mon-organisation-a-deja-des-scopes-hubee-dila branch May 15, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants