client/v3: fix open file memory leak #18200
Conversation
vivekpatani
commented
Jun 18, 2024
vivekpatani
commented
- reference: Memory leak #18085
- defer close and catch errors if unsuccessful
- reference: etcd-io#18085 - defer close and catch errors if unsuccessful Signed-off-by: vivekpatani <9080894+vivekpatani@users.noreply.github.com>
|
Hi @vivekpatani. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
|
||
| var f *os.File | ||
| f, err = os.OpenFile(partpath, os.O_WRONLY|os.O_CREATE|os.O_TRUNC, fileutil.PrivateFileMode) | ||
| defer func(f *os.File) { | ||
| err = f.Close() |
There was a problem hiding this comment.
The f can be nil here. defer should be called only if the err is nil.
There was a problem hiding this comment.
and it suffers from the same issue on Windows as I've described here:
#18086 (comment)
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
