Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flags: optimise memory allocation #19201

Merged
merged 1 commit into from
Jan 18, 2025

Conversation

arturmelanchyk
Copy link
Contributor

This PR introduces tiny optimizations by specifying len in make(map...) statements

Signed-off-by: Artur Melanchyk <arturmelanchyk@imail.name>
@k8s-ci-robot
Copy link

Hi @arturmelanchyk. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ahrtr
Copy link
Member

ahrtr commented Jan 16, 2025

/ok-to-test

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, arturmelanchyk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.84%. Comparing base (ce4b4e5) to head (dcbd309).
Report is 30 commits behind head on main.

Additional details and impacted files
Files with missing lines Coverage Δ
pkg/flags/selective_string.go 100.00% <100.00%> (ø)
pkg/flags/unique_strings.go 92.00% <100.00%> (+0.33%) ⬆️

... and 21 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19201      +/-   ##
==========================================
+ Coverage   68.82%   68.84%   +0.02%     
==========================================
  Files         420      420              
  Lines       35627    35628       +1     
==========================================
+ Hits        24519    24528       +9     
+ Misses       9688     9678      -10     
- Partials     1420     1422       +2     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce4b4e5...dcbd309. Read the comment docs.

@serathius
Copy link
Member

/retest

@arturmelanchyk
Copy link
Contributor Author

/retest

2 similar comments
@serathius
Copy link
Member

/retest

@serathius
Copy link
Member

/retest

@ahrtr ahrtr merged commit 2f37f48 into etcd-io:main Jan 18, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants