Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race condition (also a regression of the PR 19139) #19221

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Close all listeners firstly, afterwards close the server

3fa96c8
Select commit
Loading
Failed to load commit list.
Open

Fix race condition (also a regression of the PR 19139) #19221

Close all listeners firstly, afterwards close the server
3fa96c8
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 18, 2025 in 1s

68.77% (-0.04%) compared to 2f37f48

View this Pull Request on Codecov

68.77% (-0.04%) compared to 2f37f48

Details

Codecov Report

Attention: Patch coverage is 84.37500% with 5 lines in your changes missing coverage. Please review.

Project coverage is 68.77%. Comparing base (2f37f48) to head (3fa96c8).

Files with missing lines Patch % Lines
server/embed/serve.go 81.25% 1 Missing and 2 partials ⚠️
server/embed/etcd.go 87.50% 2 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
server/embed/etcd.go 75.68% <87.50%> (-0.18%) ⬇️
server/embed/serve.go 59.38% <81.25%> (+1.58%) ⬆️

... and 23 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19221      +/-   ##
==========================================
- Coverage   68.80%   68.77%   -0.04%     
==========================================
  Files         420      420              
  Lines       35650    35665      +15     
==========================================
- Hits        24529    24528       -1     
- Misses       9694     9713      +19     
+ Partials     1427     1424       -3     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f37f48...3fa96c8. Read the comment docs.