Fixed string encoding for WebPlugin webapp.py for Python3 #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing Python3 encoding incompatibilities.
Reorganizing a bit of the code as well as fix some minor errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background: Some of the intended functionality of ete3's webplugin app wasn't working properly (the WebTreeAplication's call function)
After some digging, I found out that the issue had to do with string encoding (as the native string is bytes for python2 and text for python3: https://portingguide.readthedocs.io/en/latest/strings.html) provided WSGI applications are required to yield bytes objects: Str in Python2 and bytes in Python3
My code solutions were rather simple but I tried to fix (most of) the encoding errors I was able to pinpoint through my testing.