Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the hub's configuration #9

Merged
merged 8 commits into from
Jun 12, 2024
Merged

Refactor the hub's configuration #9

merged 8 commits into from
Jun 12, 2024

Conversation

rsarm
Copy link
Collaborator

@rsarm rsarm commented Jun 12, 2024

  • Removes all the commented lines from the jhub config
  • Adds "config extras" so custom options that are non-templated can be added in the configuration via the values.yaml
  • Adds an option in the values.yaml to run the hub in debug log level
  • Changes in jupyterhub's config can be deployed with helm upgrade without affecting the users that have running servers

@rsarm rsarm self-assigned this Jun 12, 2024
@rsarm rsarm requested a review from jpdorsch June 12, 2024 10:12
@rsarm rsarm merged commit ec57197 into main Jun 12, 2024
1 check passed
@rsarm rsarm deleted the config-refactor branch June 12, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpdorsch jpdorsch Awaiting requested review from jpdorsch

Assignees

@rsarm rsarm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rsarm