Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MEV_RELAYS can now be multi-line #1968

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

yorickdowne
Copy link
Contributor

This is a fairly big change to enable one thing: Multi-line values in .env. There is one user that has their MEV_RELAYS as multi-line, and we kept breaking their .env whenever the version of the template changed.

Not touching the config workflow deeply, but that could be next - it'd make a lot of sense to re-use the Lido CSM config flow for all MEV_RELAYS purposes, or at least when MEV_RELAYS has not been set by the user, and construct multi-line during config.

That'd be a separate PR

@yorickdowne
Copy link
Contributor Author

I am merging this without review, so I can increment the .env version for the ssvlabs repo changeover. Without this, I'll break the setup of the one user that has a multi-line value :/

The awk code is GPT-generated. A review is still welcome, we may want to tighten / improve it

@yorickdowne yorickdowne merged commit eca6a92 into eth-educators:main Oct 29, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant