Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSF wiki page #243

Merged
merged 4 commits into from
Jun 8, 2024
Merged

SSF wiki page #243

merged 4 commits into from
Jun 8, 2024

Conversation

gorondan
Copy link
Contributor

@gorondan gorondan commented May 1, 2024

Wiki PR Checklist

Thank you for contributing to the Protocol Wiki! Before you open a PR, make sure to read information for contributors and take a look at following checklist:

  • [ x] Describe your changes, substitute this text with the information

Copy link

github-actions bot commented May 1, 2024

Hi @gorondan,

Following typos were found in the pull request:

  • 📄 ./docs/wiki/research/SSF.md:
    1. FFG
    2. FFG
    3. Zipfian

ℹ️ Here's how to fix them:

  • Fix typos: Open the relevant files and fix any identified typos.
  • Update wordlist: If a flagged word is actually a project-specific term add it to wordlist.txt in the project root.
    Each word should be listed on a separate line. Learn more.
  • 🚧 Remember:
    • When adding new words it MUST NOT have any spaces or special characters within or around it.
    • wordlist is NOT case sensitive.
    • Use backticks to quote code variables so as to not bloat the wordlist.


| Upgrade | URGE | Track | Topic | Cross-references |
| :-----: | :-------: | :---: | :----------------------: | :----------------------------------------------------------------------------------------------------------: |
| SSF | the Merge | - | Increase Validator count | intersection with: [MAX_EB](/docs/wiki/research/cl-upgrades.md), [ePBS](/docs/wiki/research/PBS/ePBS.md), ET |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Track could be PoS upgrades?
And topic is not increasing validator count, rather improving finality time/security/usability
Intersection could be SSLE, PBS..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking Vs picture again. It seems that SSF is part of the increasing validator count track. No topic tho, since there's only one topic and that overlaps with the track (in contrast to other urges e.g. scourge where there are multiple topics spread over 2 tracks).
So, I propose

  • track : increasing validator count
  • topic : -

Regarding intersections: SSLE seems legit. But I would keep max_eb (closely related to enabling greater validator count), and yes PBS

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overall track here should be something like PoS Improvements and topic more specific, something like faster finalization/economic security. I don't want to leave out empty columns here, otherwise I would make them optional or remove in the template for these tables.

The picture from V shouldn't be an ultimate reference tool because it's changing and doesn't reflect all realities.
SSF makes it harder to increase validator count, the more validators, the harder the aggregation in one slot. The idea in the picture is to build on top of this to make it more effective.

| :-----: | :-------: | :---: | :----------------------: | :----------------------------------------------------------------------------------------------------------: |
| SSF | the Merge | - | Increase Validator count | intersection with: [MAX_EB](/docs/wiki/research/cl-upgrades.md), [ePBS](/docs/wiki/research/PBS/ePBS.md), ET |

## What is SSF?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## What is SSF?

docs/wiki/research/SSF.md Outdated Show resolved Hide resolved
docs/wiki/research/SSF.md Outdated Show resolved Hide resolved
The delay between a block's proposal and finalization also creates an opportunity for short reorgs that an attacker could use to censor certain blocks or extract MEV.

## Benefits of SSF
* more convenient for apps - transactions finalization time improved by an order of magnitude, i.e. 12 seconds instead of 12 minutes means better UX for all Ethereum users
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use capital letters even in bullet points


Some interaction issues between the fork choice and the consensus do remain in any such design, and it’s still important to work through them.
Short-term improvements to the existing fork choice (eg. view-merge) may also feed into work on the SSF fork choice.[^2]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to use drawings from Francesco in this part, he shared the raw drawio file so you can edit it

Co-authored-by: Mário Havel <61149543+taxmeifyoucan@users.noreply.github.com>
Copy link

github-actions bot commented May 3, 2024

Hi @gorondan,

Following typos were found in the pull request:

  • 📄 ./docs/wiki/research/SSF.md:
    1. FFG
    2. FFG
    3. FFG
    4. Zipfian

ℹ️ Here's how to fix them:

  • Fix typos: Open the relevant files and fix any identified typos.
  • Update wordlist: If a flagged word is actually a project-specific term add it to wordlist.txt in the project root.
    Each word should be listed on a separate line. Learn more.
  • 🚧 Remember:
    • When adding new words it MUST NOT have any spaces or special characters within or around it.
    • wordlist is NOT case sensitive.
    • Use backticks to quote code variables so as to not bloat the wordlist.

Co-authored-by: Mário Havel <61149543+taxmeifyoucan@users.noreply.github.com>
Copy link

github-actions bot commented May 3, 2024

Hi @gorondan,

Following typos were found in the pull request:

  • 📄 ./docs/wiki/research/SSF.md:
    1. FFG
    2. FFG
    3. FFG
    4. Zipfian

ℹ️ Here's how to fix them:

  • Fix typos: Open the relevant files and fix any identified typos.
  • Update wordlist: If a flagged word is actually a project-specific term add it to wordlist.txt in the project root.
    Each word should be listed on a separate line. Learn more.
  • 🚧 Remember:
    • When adding new words it MUST NOT have any spaces or special characters within or around it.
    • wordlist is NOT case sensitive.
    • Use backticks to quote code variables so as to not bloat the wordlist.

@gorondan gorondan mentioned this pull request May 7, 2024
@taxmeifyoucan
Copy link
Contributor

The current page should be expanded later but it's beneficial to have it public now.

@taxmeifyoucan taxmeifyoucan merged commit 72d46d7 into main Jun 8, 2024
1 of 2 checks passed
Copy link

github-actions bot commented Jun 8, 2024

Hi @gorondan,

Following typos were found in the pull request:

  • 📄 ./docs/wiki/research/SSF.md:
    1. FFG
    2. FFG
    3. FFG
    4. Zipfian

ℹ️ Here's how to fix them:

  • Fix typos: Open the relevant files and fix any identified typos.
  • Update wordlist: If a flagged word is actually a project-specific term add it to wordlist.txt in the project root.
    Each word should be listed on a separate line. Learn more.
  • 🚧 Remember:
    • When adding new words it MUST NOT have any spaces or special characters within or around it.
    • wordlist is NOT case sensitive.
    • Use backticks to quote code variables so as to not bloat the wordlist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants