Add support for environment variables #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| utils.refresh_bootstrapper() | ||
| self.assertEqual(os.getenv('MANDREL_ROOT'), mandrel.bootstrap.ROOT_PATH) | ||
| expected = os.path.join(os.getenv('MANDREL_ROOT'), os.getenv('MANDREL_BOOTSTRAP_NAME')) | ||
| self.assertEqual(expected, mandrel.bootstrap.BOOTSTRAP_FILE) |
There was a problem hiding this comment.
I'm happy to see tests, but this changes too much core stuff for a single test case to cover.
Given that you're introducing two changes (the mandrel root variable; the bootstrap basename variable), the cases to consider are considerably more complicated:
- Base case: neither variable is defined (the original behaviors)
- Root is specified, bootstrapper is not,
Mandrel.pyis present in specified root (should parse the file it finds) - Root is specified, bootstrapper is not,
Mandrel.pyis not present in specified root (should get basic defaults) - Root is specified, bootstrapper is specified, the specified file exists in the specified root
- Root is specified, bootstrapper is specified, the specified file does not exist in the specified root
- Root is not specified, bootstrapper is specified, the specified file exists; it should be used and the root should be where that guy was found. This would need testing at various file system levels.
- Root is not specified, bootstrapper is specified, the specified file does not exist within the file system hierarchy; this should blow up, just like it does now if
Mandrel.pycan't be found.
So there's quite a few test cases that would need to be covered.
It's considerably simpler if only one of the issues is done: either specifying a root, or specifying a basename, but not both.
But as it stands, the test only covers the case where both are set, it doesn't treat them separately.
|
@ethanrowe Apologies for the extremely slow turn-around on this. I added a bunch of tests to the PR to address the scenarios you outlined above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses the following two issues