Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ feat(Pointer Schema): Better validation errors for pointer schema. #88

Merged
merged 2 commits into from
Apr 21, 2024
Merged

✨ feat(Pointer Schema): Better validation errors for pointer schema. #88

merged 2 commits into from
Apr 21, 2024

Conversation

raxhvl
Copy link
Contributor

@raxhvl raxhvl commented Apr 20, 2024

Closes #87.

gnidan
gnidan requested changes Apr 20, 2024
View reviewed changes
Copy link
Member

@gnidan gnidan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix needed to get the build to pass. Thanks for investigating this!

schemas/pointer.schema.yaml Outdated Show resolved Hide resolved
@raxhvl @gnidan
location: required
2227691 
Co-authored-by: g. nicholas d'andrea <gnidan@users.noreply.github.com>
@raxhvl
Copy link
Contributor Author

raxhvl commented Apr 21, 2024

@gnidan my bad I thought yarn start runs tests too. I'll be sure to run yarn test when pushing changes. Your suggestions fixes the test; your explanation was intuitive too. Thanks!

@gnidan
Copy link
Member

gnidan commented Apr 21, 2024

Awesome! Weird about yarn start - are you running it from the repo root?

@gnidan gnidan merged commit 86677b9 into ethdebug:main Apr 21, 2024
4 checks passed
@raxhvl
Copy link
Contributor Author

raxhvl commented Apr 22, 2024

Awesome! Weird about yarn start - are you running it from the repo root?

Yep.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnidan gnidan gnidan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve validation error reporting for pointer schema
2 participants
@raxhvl @gnidan