Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove is_valid_block_hash change in Deneb #3441

Closed
wants to merge 1 commit into from

Conversation

ppopth
Copy link
Member

@ppopth ppopth commented Jun 23, 2023

Since is_valid_block_hash is used in consensus-specs only for describing what verify_and_notify_new_payload does, is_valid_block_hash does not really exist in the clients.

is_valid_block_hash shouldn't accept parent_beacon_block_root, since it has nothing to do with them.

verify_and_notify_new_payload accepts parent_beacon_block_root and corresponds to engine_newPayloadV3, but is_valid_block_hash doesn't have to do the same.

@mkalinin
Copy link
Collaborator

is_valid_block_hash shouldn't accept parent_beacon_block_root, since it has nothing to do with them.

parentBeaconBlockRoot is a part of EL block but not a part of ExecutionPayload, CL must pass it to block hash verification, otherwise, EL won't be able to compute the actual block hash and do the validation

Since is_valid_block_hash is used in consensus-specs only for describing
what verify_and_notify_new_payload does, is_valid_block_hash does not
really exist in the clients.

is_valid_block_hash shouldn't accept parent_beacon_block_root, since it
has nothing to do with them.

verify_and_notify_new_payload accepts parent_beacon_block_root and
corresponds to engine_newPayloadV3, but is_valid_block_hash doesn't have
to do the same.
@ppopth ppopth force-pushed the remove-deneb-is-valid-block-hash branch from d5a01eb to 6b81f81 Compare June 23, 2023 08:35
@ppopth
Copy link
Member Author

ppopth commented Jun 23, 2023

parentBeaconBlockRoot is a part of EL block but not a part of ExecutionPayload, CL must pass it to block hash verification, otherwise, EL won't be able to compute the actual block hash and do the validation

Alright, got it. Thanks.

@ppopth ppopth closed this Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants