Remove is_valid_block_hash change in Deneb #3441
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
is_valid_block_hash
is used in consensus-specs only for describing whatverify_and_notify_new_payload
does,is_valid_block_hash
does not really exist in the clients.is_valid_block_hash
shouldn't acceptparent_beacon_block_root
, since it has nothing to do with them.verify_and_notify_new_payload
acceptsparent_beacon_block_root
and corresponds to engine_newPayloadV3, butis_valid_block_hash
doesn't have to do the same.