Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds slash_proposer function #3450

Closed
wants to merge 75 commits into from
Closed

Adds slash_proposer function #3450

wants to merge 75 commits into from

Conversation

mkalinin
Copy link
Collaborator

A new function has the following properties:

  • Constant penalty borrowed from Constant penalty for proposer equivocations michaelneuder/consensus-specs#7
    • we might want to redefine proposer reward constants for this new function as the PR reduces the reward by a factor of validator.effective_balance // 4 which is 8 in the worst case today
  • Sets slashed flag to true retaining replay protection and the timeout during which slashing can be accepted even if validator has exited after equivocation
  • Does not reset withdrawable_epoch as regular slashing does
  • Slashed proposer can still be a subject to correlated penalties but only if exit churn is longer than EPOCHS_PER_SLASHINGS_VECTOR // 2 - MIN_VALIDATOR_WITHDRAWABILITY_DELAY (=3,840) epochs. Which is roughly 46,080 validators queued for exit at 786,432 validator set size

michaelneuder and others added 30 commits May 21, 2023 09:39
@michaelneuder
add full capella pyspec
7d7398d
@michaelneuder
mvp
0b8bb11
@michaelneuder
partial withdrawals
6809439
@michaelneuder
top ups
2b1c7b8
@michaelneuder
top ups
6824f17
@michaelneuder
top ups
67cc34f
@michaelneuder
all top ups capped at 32 ETH
1403bdb
@fradamt
simplify top-up
cb49250
@michaelneuder
update get_expected_withdrawals
81f9080
@michaelneuder
Merge branch 'maxeb-pyspec-min-viable' of https://github.com/michaeln…
3575804 
…euder/consensus-specs into maxeb-pyspec-min-viable
@michaelneuder
ceiling function
95a167d
@michaelneuder
remove proposer slashing modification –– permature optimizaiton IMO
604b876
@michaelneuder
rm MIN_PROPOSER_SLASHING
552cb21
@michaelneuder
balance - ceiling
fdcb6bd
@michaelneuder
justin round 1
2e536a4
@michaelneuder
remove virtual
2526b9d
@michaelneuder
remove whitespace
b6c476f
@michaelneuder
min_balance_incrememts
4681d67
@michaelneuder
min_balance_increments
921e898
@michaelneuder
compute_weak_subjectivity_period
b6d5f07
@michaelneuder
justin rd 2 comments
8e56d72
@michaelneuder
justin rd 2 comments
7b5ad56
@michaelneuder
new initiate_validator_exit logic
7e1408c
@michaelneuder
new activation and exit logic
4b1ee30
@michaelneuder
justin rd 3 :-)
2ad9633
@michaelneuder
rollback
d6db57c
@michaelneuder
update with pending deposits rate limited by churn
bcd6164
@michaelneuder
make pending balance deposit a list
2955027
@michaelneuder
dapplion response
1577082
@michaelneuder
small fix
6f8c3e1
michaelneuder and others added 29 commits July 3, 2023 12:39
@michaelneuder
remove unused local
c063473
@fradamt
fix typos
9c141fc
@fradamt
- Fix typos and small errors
88f650b 
- Make exits withdraw the full balance instead of whater was available when exit is initiated
- Adjust withdrawal amount to be at most balance - 32
- Adjust withdrawable epoch for partial withdrawal when processed after slashing
@michaelneuder
cancel pending withdrawals
a39d578
@dapplion
Add process_execution_layer_withdraw_request
022deb9
@mkalinin
Handle slashings in exit withdrawal queue
b57a7ce
@mkalinin
Remove unprocessed exit upon slashing
ec33407
@mkalinin
Do not break if withdrawable epoch is not yet come
63b3633
@michaelneuder
Merge pull request #5 from michaelneuder/exit-withdrawal-queue
ccf5acf 
Updates of pending withdrawals queue processing
@michaelneuder
two queues
f73a996
@michaelneuder
two queues
82d49cf
@michaelneuder
three queue:
986e6ad
@michaelneuder
three queue
f4f6538
@mkalinin
Implement exit churn with no physical queue, add partial withdrawals
7801942
@mkalinin
Fix consumed update
fd8aa04
@mkalinin
Fix expected withdrawals
f23f77c
@mkalinin
Polish names
a6c62be
@mkalinin
Skip partial withdrawals if validator exited
3e927cf
@mkalinin
Remove unused fields and functions
f87def1
@mkalinin
Cleanup get_expected_withdrawals
fa8f2ee
@mkalinin
Limit partial withdrawals to MAX_WITHDRAWALS_PER_PAYLOAD // 2
b489655
@michaelneuder
Merge pull request #6 from michaelneuder/queueless-exit-churn
6f4750d 
Queueless exit churn
@michaelneuder
compute_exit_epoch_and_update_churn tweak
ccc0aae
@michaelneuder
fix consumed increment indentation level
f7b74c3
@michaelneuder
add decrease_balance
ff9197c
@michaelneuder
rm decrease_balance
31e056e
@mkalinin
Revert changes in slash_validator
d253ead
@fradamt
remove unused field, withdrawal_balance_to_consume
be4797b
@mkalinin
Add slash_proposer
048069b
@mkalinin mkalinin closed this Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mkalinin @michaelneuder @fradamt @dapplion