Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove BLOB_TX_TYPE from spec (and move to tests) #3534

Merged
merged 1 commit into from
Oct 30, 2023
Merged

remove BLOB_TX_TYPE from spec (and move to tests) #3534

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion specs/deneb/beacon-chain.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@ Deneb is a consensus-layer upgrade containing a number of features. Including:

| Name | Value |
| - | - |
| `BLOB_TX_TYPE` | `uint8(0x03)` |
| `VERSIONED_HASH_VERSION_KZG` | `Bytes1('0x01')` |

## Preset
Expand Down
6 changes: 5 additions & 1 deletion tests/core/pyspec/eth2spec/test/helpers/sharding.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
Union,
boolean,
uint256, uint64,
uint8,
)
from eth2spec.utils.ssz.ssz_impl import serialize

Expand All @@ -20,6 +21,9 @@
MAX_ACCESS_LIST_SIZE = 2**24


BLOB_TX_TYPE = uint8(0x03)


class AccessTuple(Container):
address: Bytes20 # Address = Bytes20
storage_keys: List[Bytes32, MAX_ACCESS_LIST_STORAGE_KEYS]
Expand Down Expand Up @@ -120,5 +124,5 @@ def get_sample_opaque_tx(spec, blob_count=1, rng=random.Random(5566), is_valid_b
)
)
serialized_tx = serialize(signed_blob_tx)
opaque_tx = spec.uint_to_bytes(spec.BLOB_TX_TYPE) + serialized_tx
opaque_tx = spec.uint_to_bytes(BLOB_TX_TYPE) + serialized_tx
return opaque_tx, blobs, blob_kzg_commitments, blob_kzg_proofs