-
Notifications
You must be signed in to change notification settings - Fork 975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v1.5.0-alpha.4 #3853
Merged
Release v1.5.0-alpha.4 #3853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hwwhww
commented
Jul 24, 2024
•
edited
Loading
edited
- testgen
- version bump bump to 1.5.0-alpha.4 #3865
- Add MetadataV3 with custody_subnet_count #3821
- Fix off-by-one in process_pending_consolidations #3868
The name `get_safe_execution_payload_hash` is misleading, as it returns the execution block hash. There is no concept of a payload hash. Rename the function, and also update some documentation for clarity.
- describe sample selection - describe sample queries Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
Clarify that what matters is the false positive threshold, allowing different sampling strategies as protocol compliant behavior. Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
While the technique was introduced as LossyDAS, we don't need the name in the specification itself. Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
add LossyDAS sample count generation helper function Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
Importing scipy is not preferred. This is a self-contained version. Eventually an import of math and use of math.comb makes it simpler. Solving other formatting issues as well. Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
- when should a node reconstruct - how to cross-seed for subscribed and unsubscribed topics Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
Bump remerkleable to `v0.1.28`
Add Electra merkle proof test vectors
On macOS Python, passing `10e10` to `rng.randint` results in an error when generating certain tests. Forcing `int` avoids the problem.
Electra introduces two changes that affect light client data handling: 1. The `ExecutionPayloadHeader` is extended with new fields. This is handled similarly as before with the Deneb fork. 2. The `BeaconState` generalized indices change due to lack of EIP-6493. This is handled by making the generalized index be fork dependent via a helper function that computes it dynamically. Furthermore, the case where pre-Electra light client data is consumed by an Electra based `LightClientStore` requires normalizing the shorter proof of the pre-Electra data to fit into the Electra data structure by prepending a zero hash.
…add assertions to test cases
Fix typing issue when `10e10` is interpreted as float
Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
…le content in the spec
Somehow (probably because of a merge conflict) the last three verify_cell_kzg_proof_batch test cases were indented too far and as a result were part of the loop above, and as a result executed multiple times. This doesn't change the generated tests because it would try to do the same test with the same inputs.
Fix indentation for some kzg_7594 tests
For pytest, replace NUMBER_OF_CORES with auto
EIP7594: Improve Documentation in Recovery Code
Update description for test format
Rename `get_safe_execution_payload_hash` -> `*_block_hash`
EIP7594: Remove dead link
Fix spec error in get_generalized_index function
bump to 1.5.0-alpha.4
Add MetadataV3 with custody_subnet_count
EIP-7732: Enshrined Proposer-Builder Separation
Co-authored-by: fradamt <104826920+fradamt@users.noreply.github.com>
EIP-7732(p2p): clean up `payload_attestation_message` conditions
Fix nits in eip7594 p2p-interface spec
Fix off-by-one in process_pending_consolidations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.