Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.5.0-alpha.4 #3853

Merged
merged 163 commits into from
Aug 9, 2024
Merged

Release v1.5.0-alpha.4 #3853

merged 163 commits into from
Aug 9, 2024

Conversation

hwwhww
Copy link
Contributor

@hwwhww hwwhww commented Jul 24, 2024

etan-status and others added 30 commits February 8, 2024 09:50
The name `get_safe_execution_payload_hash` is misleading, as it returns
the execution block hash. There is no concept of a payload hash. Rename
the function, and also update some documentation for clarity.
- describe sample selection
- describe sample queries

Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
Clarify that what matters is the false positive threshold, allowing
different sampling strategies as protocol compliant behavior.

Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
While the technique was introduced as LossyDAS, we don't need the name
in the specification itself.

Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
add LossyDAS sample count generation helper function

Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
Importing scipy is not preferred. This is a self-contained
version. Eventually an import of math and use of math.comb
makes it simpler.
Solving other formatting issues as well.

Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
- when should a node reconstruct
- how to cross-seed for subscribed and unsubscribed topics

Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
On macOS Python, passing `10e10` to `rng.randint` results in an error
when generating certain tests. Forcing `int` avoids the problem.
Electra introduces two changes that affect light client data handling:

1. The `ExecutionPayloadHeader` is extended with new fields.
   This is handled similarly as before with the Deneb fork.

2. The `BeaconState` generalized indices change due to lack of EIP-6493.
   This is handled by making the generalized index be fork dependent via
   a helper function that computes it dynamically. Furthermore, the case
   where pre-Electra light client data is consumed by an Electra based
   `LightClientStore` requires normalizing the shorter proof of the
   pre-Electra data to fit into the Electra data structure by prepending
   a zero hash.
Fix typing issue when `10e10` is interpreted as float
Signed-off-by: Csaba Kiraly <csaba.kiraly@gmail.com>
jtraglia and others added 13 commits July 25, 2024 17:07
Somehow (probably because of a merge conflict) the last three
verify_cell_kzg_proof_batch test cases were indented too far and as a result
were part of the loop above, and as a result executed multiple times. This
doesn't change the generated tests because it would try to do the same test
with the same inputs.
Fix indentation for some kzg_7594 tests
For pytest, replace NUMBER_OF_CORES with auto
EIP7594: Improve Documentation in Recovery Code
Rename `get_safe_execution_payload_hash` -> `*_block_hash`
EIP7594: Remove dead link
@hwwhww hwwhww marked this pull request as ready for review August 3, 2024 06:04
@hwwhww hwwhww merged commit 6a842b4 into master Aug 9, 2024
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.