Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve check_toc rule in Makefile #3937

Merged
merged 3 commits into from
Sep 24, 2024
Merged

Conversation

jtraglia
Copy link
Member

@jtraglia jtraglia commented Sep 20, 2024

This PR is a little update which makes the check_toc easier to understand. Here's what it looks like:

image image

(note, these screenshots were take with a mistake & don't list _features files)

Specifically, this PR does the following:

  • Check all files instead of stopping at the first difference.
  • Hide unnecessary command output & print simple good/bad message with color.
  • Tell reader there's a saved tmp file.

Copy link
Member

@ralexstokes ralexstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good, nice work!

Copy link
Contributor

@hwwhww hwwhww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Good Good.

@hwwhww hwwhww merged commit c6d4c2e into ethereum:dev Sep 24, 2024
26 checks passed
@jtraglia jtraglia deleted the improve-check-toc branch September 24, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants