Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a negative test for inactive validator for withdrawal request #3945

Merged

Conversation

terencechain
Copy link
Contributor

I noticed that by commenting out the inactive check for process_withdrawal_request, the test still passes. This PR adds a test case to ensure an inactive validator doesn't pass. It's my first time adding a spec test, so it may be off. Note to the reviewer: feel free to push any changes to my PR as needed

    # Verify the validator is active
    if not is_active_validator(validator, get_current_epoch(state)):
        return

@terencechain terencechain force-pushed the withdrawal-request-inactive-validator-test branch 3 times, most recently from 590ee40 to 1b4f901 Compare September 26, 2024 21:34
@terencechain terencechain force-pushed the withdrawal-request-inactive-validator-test branch from 1b4f901 to a4837a5 Compare September 26, 2024 21:38
Copy link
Member

@jtraglia jtraglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you 👍

@jtraglia jtraglia merged commit a6294c6 into ethereum:dev Oct 2, 2024
26 checks passed
@Godstimendako

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants